> On March 30, 2014, 12:15 a.m., Martin Klapetek wrote: > > Thanks for the patch > > > > Can I ask first what is this trying to fix/improve?
Oh sorry I see you put it in the description which I overlooked :) So I think there's a different and possibly better way to fix this - you can just remember the value the user typed when switching the presence type and just keep it present, this should save quite some complexity and handling code. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117165/#review54568 ----------------------------------------------------------- On March 29, 2014, 9:22 p.m., Siddhartha Sahu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117165/ > ----------------------------------------------------------- > > (Updated March 29, 2014, 9:22 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-contact-list > > > Description > ------- > > Before this, changing the presence type removed the already typed in text. > > > Diffs > ----- > > dialogs/custom-presence-dialog.h 4c2cca63fa077d28f567ace54adcf8373810a5e0 > dialogs/custom-presence-dialog.cpp 5e7b76eb084c5cb1dbf834228ee9bfcf3ae271d4 > > Diff: https://git.reviewboard.kde.org/r/117165/diff/ > > > Testing > ------- > > Adding and removing presences work as before. > > > File Attachments > ---------------- > > Screenshot > > https://git.reviewboard.kde.org/media/uploaded/files/2014/03/29/81e4f307-b0e7-499c-8b2f-d51a3cdc19e8__ss.png > > > Thanks, > > Siddhartha Sahu > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
