----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117180/#review54581 -----------------------------------------------------------
contact-list-widget.cpp <https://git.reviewboard.kde.org/r/117180/#comment38175> This should be parented contact-list-widget.cpp <https://git.reviewboard.kde.org/r/117180/#comment38176> I'm not sure if "enable" is the right word here...we're not enabling anything in the sense of QWidget::setEnabled but we're adding the module to the dialog, so I'd like this to be named "addGeneralSettingsModule()" rather than enable contact-list-widget.cpp <https://git.reviewboard.kde.org/r/117180/#comment38177> Space between arguments; this is also horribly wrong (I know it's not your code), can we make it autosize and not hardcode to magic values? - Martin Klapetek On March 30, 2014, 10:05 a.m., Siddhartha Sahu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117180/ > ----------------------------------------------------------- > > (Updated March 30, 2014, 10:05 a.m.) > > > Review request for Telepathy. > > > Repository: ktp-contact-list > > > Description > ------- > > Ported from ktp-contact-list's contact-list-widget.cpp > > > Diffs > ----- > > contact-list-widget.cpp ffae7bf2acdfa54932e6bc1ba3724f5fae808223 > > Diff: https://git.reviewboard.kde.org/r/117180/diff/ > > > Testing > ------- > > Settings dialog successfully opens > > > Thanks, > > Siddhartha Sahu > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
