> On March 26, 2014, 11:58 a.m., David Edmundson wrote: > > telepathy-module.cpp, line 161 > > <https://git.reviewboard.kde.org/r/116940/diff/2/?file=257308#file257308line161> > > > > I don't understand this (and this is in the previous code) > > > > Why would we call setPresence when the requestedPresence has changed. > > James Smith wrote: > When the nowPlaying engine finishes playing or changes tracks sometimes > the status message isn't properly cleared or updated. This is just another > check to make certain the status message is kept current, for example when > the presence applet changes presences. > > On testing with the above changes, this code is now redundant.
>On testing with the above changes, this code is now redundant. Well that does make me like this patch more :) Should we clean that up then? - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116940/#review54175 ----------------------------------------------------------- On March 30, 2014, 3:15 a.m., James Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116940/ > ----------------------------------------------------------- > > (Updated March 30, 2014, 3:15 a.m.) > > > Review request for Telepathy. > > > Bugs: 332082 > http://bugs.kde.org/show_bug.cgi?id=332082 > > > Repository: ktp-kded-module > > > Description > ------- > > Fixes engage-nowPlaying-from-custom-status-message and lessens disk activity > on presence change. Also simplifies logic used to keep telepathy-kded-module > in a "fit" state during run-time. > > > Diffs > ----- > > telepathy-module.cpp 030a0d9 > telepathy-module.h 2213cdf > > Diff: https://git.reviewboard.kde.org/r/116940/diff/ > > > Testing > ------- > > Compile, run. > > > Thanks, > > James Smith > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
