----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114480/ -----------------------------------------------------------
(Updated April 2, 2014, 2:54 p.m.) Status ------ This change has been discarded. Review request for Telepathy, David Edmundson and Martin Klapetek. Repository: ktp-contact-list Description ------- According to Google Code-In 2013 task (http://www.google-melange.com/gci/task/view/google/gci2013/5845533033758720) and a KDE Bug (https://bugs.kde.org/show_bug.cgi?id=316591): Now, preferences tool icon is a QToolButton basically, so it's not an actual visual children (in terms of UI/UX) of the tool bar and its behaviour is broken: when you decrese contact list, so it hides it's not displayed inside additional action list (right arrow), because it's not an action. This patch fixes it's behaviour by making this a QAction + adjusting some stuff Diffs ----- main-widget.cpp 93574d9 Diff: https://git.reviewboard.kde.org/r/114480/diff/ Testing ------- Visually looks good and no compiler/runtime/console errors. File Attachments ---------------- Regular view https://git.reviewboard.kde.org/media/uploaded/files/2013/12/15/d6f2c653-37a5-461d-9624-4f6e5df67281__Window-Regular.png Window narrowed https://git.reviewboard.kde.org/media/uploaded/files/2013/12/15/21ef3aa3-a969-489c-938c-0af7cb5f3556__Window-Narrow.png Bugfix "in action" https://git.reviewboard.kde.org/media/uploaded/files/2013/12/15/e6348ed3-b722-49fe-95fe-9e8384b04214__Window-Exposed.png Thanks, Illya Kovalevskyy
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
