> On April 6, 2014, 11:42 a.m., David Edmundson wrote: > > Amandeep do you have commit access? > > Amandeep Singh wrote: > Hi, Yes I do have commit access. > I pushed my commits to the master branch of krfb.
So can I close this review request? - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115499/#review55061 ----------------------------------------------------------- On Feb. 18, 2014, 2:43 p.m., Amandeep Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115499/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2014, 2:43 p.m.) > > > Review request for Telepathy and George Kiagiadakis. > > > Repository: krfb > > > Description > ------- > > Season of KDE Project - KRFB > > Status Quo > ----------- > Currently KRFB works on an invite-only model, where the host user needs to > create an invite via the Invitation Dialog. > This provides the connection details (address and password), which must then > be communicated to the remote user. > No information about telepathy contacts with whom desktop can be shared is > present in the KRFB Dialog. > The implementation of RFB also lacks support of clipboard operations like cut > and paste of text. > > Changes > ------- > Krfb modified to move away from invite-model, and modeled as a service that > can be started/stopped. > Bidirectional text-clipboard operations are supported. > Telepathy contacts with rfb capability shown inside main window, with an > option to share desktop. > Desktop sharing password visible in main window, with option to change it. > Unattended Access allowed with separate password. > Fixed bugs in libvncserver responsible for KRFB crashing. > Krfb now runs as KUniqueApplication. > > All changes are present in the following clone of KRFB > > Repository > ---------- > http://quickgit.kde.org/?p=clones%2Fkrfb%2Famandeepsingh%2Fkrfb-sok.git > > > Diffs > ----- > > krfb/invitationsrfbclient.cpp bd5cff8 > krfb/invitationsrfbserver.cpp 47ed934 > krfb/mainwindow.cpp PRE-CREATION > krfb/rfbclient.h 7b46d3f > krfb/rfbclient.cpp 9ab16eb > krfb/rfbserver.cpp cd5d6c0 > krfb/tubesrfbserver.cpp 575c3cd > krfb/ui/mainwidget.ui PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/115499/diff/ > > > Testing > ------- > > > Thanks, > > Amandeep Singh > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
