----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117534/#review55570 -----------------------------------------------------------
I'm not 100% sure we want to reuse the existing persist feature; one is for debugging to mean never close, in the case of the text-ui we may as well still close if there are no open group chats. I'll revisit this when I see the text-ui patch and see the intended usage. KTp/telepathy-handler-application.cpp <https://git.reviewboard.kde.org/r/117534/#comment38670> typo in arg name You want either persist or priestess. Probably the first one. - David Edmundson On April 13, 2014, 10:07 a.m., Dan Vrátil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117534/ > ----------------------------------------------------------- > > (Updated April 13, 2014, 10:07 a.m.) > > > Review request for Telepathy. > > > Repository: ktp-common-internals > > > Description > ------- > > This patch adds persist bool argument to ctors of > TelepathyHandlerApplication, which allows applications to force the > persistent mode (like passing --persist to command line). This is needed for > ktp-text-ui in order to stay alive and keep group chats channels opened even > when all windows are closed. > > Secondly, this patch makes THA actually persist even when last window is > closed. This is because each KMainWindow holds one KGlobal reference and > KGlobal::deref() will call QApplication::quit() regardless of > setQuitOnLastWindowClosed(). To prevent this from happening, THA is now > holding one reference indefinitely, which means that the application can only > be terminated by an explicit call to QApplication::quit() from the > application itself. > > > Diffs > ----- > > KTp/telepathy-handler-application.h fbdb523 > KTp/telepathy-handler-application.cpp 2b5d608 > > Diff: https://git.reviewboard.kde.org/r/117534/diff/ > > > Testing > ------- > > > Thanks, > > Dan Vrátil > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
