----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117564/#review55760 -----------------------------------------------------------
Ship it! Ship It! KTp/Widgets/join-chat-room-dialog.h <https://git.reviewboard.kde.org/r/117564/#comment38794> Maybe call this setJoinInProgress to have a 1:1 mapping to the member variable name. Also there is a new newline inserted here that isn't necessary. KTp/Widgets/join-chat-room-dialog.cpp <https://git.reviewboard.kde.org/r/117564/#comment38795> This also happens in ktp-contactlist, so you should remove the code there. - Leon Handreke On April 14, 2014, 3:23 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117564/ > ----------------------------------------------------------- > > (Updated April 14, 2014, 3:23 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-common-internals > > > Description > ------- > > Add warning inside join chat dialog if connection fails > > Start the text channel request from within join chat dialog, we then > monitor this for errors and display a KMessageWidget if applicable > > > Diffs > ----- > > KTp/Widgets/join-chat-room-dialog.h 1b69f25 > KTp/Widgets/join-chat-room-dialog.cpp 710eb87 > KTp/Widgets/join-chat-room-dialog.ui 058362d > > Diff: https://git.reviewboard.kde.org/r/117564/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
