> On April 15, 2014, 9:29 a.m., Thomas Pfeiffer wrote: > > I can only see one selectbox to choose the image sharing service in the > > configuration. What if people simply don't want this feature enabled at all? > > Ahmed Ibrahim wrote: > Isn't that the purpose of David's suggestion about the context menu > appearing when dropping an image ? If the user does not want to share image > he can choose the file transfer option.
These are two different things: One is a decision on a case-by-case basis, the other is a general decision. If a user simply doesn't want to share images publicly on the web, that user should have the ability to switch the feature off instead of having to choose "send image directly" each time they drag an image into a chat. Maybe we can have an element "Do not use image sharing" in the select box and default to that, and as long as this element is selected, do not show the menu but always send file directly? - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117573/#review55799 ----------------------------------------------------------- On April 14, 2014, 11:18 p.m., Ahmed Ibrahim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117573/ > ----------------------------------------------------------- > > (Updated April 14, 2014, 11:18 p.m.) > > > Review request for Telepathy and David Edmundson. > > > Bugs: 322874 > http://bugs.kde.org/show_bug.cgi?id=322874 > > > Repository: ktp-text-ui > > > Description > ------- > > I've wrote an extensible image sharer library that can upload images to > Imgur, Simplest Image Host and ImageBin, the library can be extended to > support other services like wstaw.org for example. I've integrated the > library with text-ui and used it to share images to the choosed service when > dragging it to the text-ui. > > I've added a new "Image Sharing" configuration item under the Chat Tab > Behaviour, you will find the screenshot attached. > > > Diffs > ----- > > CMakeLists.txt eabecd9 > config/CMakeLists.txt a8e7cd9 > config/behavior-config.h d57fd90 > config/behavior-config.cpp eeb3597 > config/behavior-config.ui c8e731c > image-sharer/CMakeLists.txt PRE-CREATION > image-sharer/abstractsharer.h PRE-CREATION > image-sharer/abstractsharer.cpp PRE-CREATION > image-sharer/cmake/CMakeLists.txt PRE-CREATION > image-sharer/cmake/modules/FindQJson.cmake PRE-CREATION > image-sharer/imagebinsharer.h PRE-CREATION > image-sharer/imagebinsharer.cpp PRE-CREATION > image-sharer/imagesharer_export.h PRE-CREATION > image-sharer/imgursharer.h PRE-CREATION > image-sharer/imgursharer.cpp PRE-CREATION > image-sharer/mpform.h PRE-CREATION > image-sharer/mpform.cpp PRE-CREATION > image-sharer/shareprovider.h PRE-CREATION > image-sharer/shareprovider.cpp PRE-CREATION > image-sharer/simplestimagehostingsharer.h PRE-CREATION > image-sharer/simplestimagehostingsharer.cpp PRE-CREATION > lib/CMakeLists.txt d640536 > lib/chat-widget.h d9c4e60 > lib/chat-widget.cpp d130529 > lib/text-chat-config.h e0ba24f > lib/text-chat-config.cpp 57c7c0c > > Diff: https://git.reviewboard.kde.org/r/117573/diff/ > > > Testing > ------- > > Dragged an image to the text-ui and the image url is appended and sent to the > other endpoint of the conversation. > > > File Attachments > ---------------- > > A screenshot of an uploaded image to the three supported image sharing > services > > https://git.reviewboard.kde.org/media/uploaded/files/2014/04/14/1a00a5d6-dd2e-4b58-a25b-c456d4adc89e__ktp-text-ui-share.png > Image Sharing Settings under the Chat Tab Behaviour > > https://git.reviewboard.kde.org/media/uploaded/files/2014/04/14/546bdac8-a803-48ac-a79c-0b5a8ba2a392__snapshot4.png > > > Thanks, > > Ahmed Ibrahim > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
