----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117659/#review56167 -----------------------------------------------------------
Ship it! src/personsmodel.cpp <https://git.reviewboard.kde.org/r/117659/#comment39200> By using "d->personIndex[personId]" directly we could save some index(..) calls (same everywhere else)...not sure about the real gain tho - Martin Klapetek On April 22, 2014, 10:20 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117659/ > ----------------------------------------------------------- > > (Updated April 22, 2014, 10:20 a.m.) > > > Review request for Telepathy. > > > Repository: libkpeople > > > Description > ------- > > Make PersonModel faster > > Instead of performing a hash lookup in each data() call, we store > MetaContacts in the list and instead use the hash to the index only > for insertion/deletion. > > > Diffs > ----- > > src/personsmodel.cpp 6a7f9b9 > > Diff: https://git.reviewboard.kde.org/r/117659/diff/ > > > Testing > ------- > > Merged, unmerged. Checked in callgrind that qHash isn't being abused. > There's still a few optimisations that could be done, but now PersonsModel > isn't the block. > > Cachegrind attached, before on the left. > > > File Attachments > ---------------- > > ktp1.png > > https://git.reviewboard.kde.org/media/uploaded/files/2014/04/20/73f56f9e-469e-4fc7-b28a-bf5dfc39b238__ktp1.png > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
