> On April 23, 2014, 9:43 p.m., Martin Klapetek wrote: > > app/chat-window.cpp, line 351 > > <https://git.reviewboard.kde.org/r/117729/diff/1/?file=268013#file268013line351> > > > > The indentation is 4 spaces ;)
Thanks for pointing out ! - Ahmed ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117729/#review56317 ----------------------------------------------------------- On April 23, 2014, 9:46 p.m., Ahmed Ibrahim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117729/ > ----------------------------------------------------------- > > (Updated April 23, 2014, 9:46 p.m.) > > > Review request for Telepathy. > > > Bugs: 333742 > http://bugs.kde.org/show_bug.cgi?id=333742 > > > Repository: ktp-text-ui > > > Description > ------- > > This bug happens when the user has switched the keyboard layout of a chat tab > and then switched to another application with another language, And he > received a message or an "is typing" chat status, the language is then > changed to the language of the Chat Tab that he was previously in, which is > of course is an annoying behavior. > > The reason of this behavior is that the restoreKeyboardLayout method is > called inside the onCurrentIndexChanged without making sure that the Chat > Window is active. > > > Diffs > ----- > > app/chat-window.cpp a7da574 > > Diff: https://git.reviewboard.kde.org/r/117729/diff/ > > > Testing > ------- > > Changed language of the Chat Tab and then went to chromium and sent a message > to myself from another account, that language did not change. > Also tried composing a message to myself from another account and the > language did not change. > > > Thanks, > > Ahmed Ibrahim > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
