----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117968/ -----------------------------------------------------------
Review request for Telepathy. Repository: ktp-common-internals Description ------- Two commits: ---- Share the same QString for all KABC Custom fields We should have a theoretically smaller memory footprint. ---- Map connection presence type to string In libkpeople we pass the presence around as a string as that's all KABC::custom() supports. We used to use presence->status(); this is problematic as it is free text which can contain anything; especially when on multiple protocols. A presence might have the status "chat" which is mapped to the presence type Tp::ConnectionPresenceTypeOnline. We want to use this mapping and only have a subset of presence strings. BUG: 334207 Diffs ----- kpeople/datasourceplugin/im-persons-data-source.cpp 44e2d5c Diff: https://git.reviewboard.kde.org/r/117968/diff/ Testing ------- Thanks, David Edmundson
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
