----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117977/#review57213 -----------------------------------------------------------
global-presence-chooser.cpp <https://git.reviewboard.kde.org/r/117977/#comment39875> Set your text editor up to clean up whitespace Kate has an option under file/save global-presence-chooser.cpp <https://git.reviewboard.kde.org/r/117977/#comment39874> QString("foo %1 %2).arg("a", "b") is better than QString("foo %1 %2").arg("a").arg("b") it makes a different if the first argument contains a % sign. Also it's faster as it does it in one pass. - David Edmundson On May 3, 2014, 5:49 p.m., Olaf Piesche wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117977/ > ----------------------------------------------------------- > > (Updated May 3, 2014, 5:49 p.m.) > > > Review request for Telepathy. > > > Bugs: 333604 > http://bugs.kde.org/show_bug.cgi?id=333604 > > > Repository: ktp-contact-list > > > Description > ------- > > Scaling icons in the presence chooser tool tip. The tooltip contains HTML, > and the icons for accounts weren't scaled at all. > > > Diffs > ----- > > global-presence-chooser.cpp 9eded30 > > Diff: https://git.reviewboard.kde.org/r/117977/diff/ > > > Testing > ------- > > Ran locally. Hovered until tooltip opened. > > > Thanks, > > Olaf Piesche > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
