> On May 8, 2014, 10:23 a.m., James Smith wrote: > > There was a problem IIRC with the signal form of > > onRequestedPresenceChanged() not the m_globalPresence->requestedPresence(). > > The onRequestedPresenceChanged() signal doesn't set the presence properly > > when accounts are disabled in the accounts kcm. Couldn't using > > m_globalPresence->requestedPresence() cause problems when the > > requestedPresence() isn't actually what the account is set to? For > > instance, now, when the currentPresence() is Away and the account presence > > is Away, the plugin won't activate. If the requestedPresence() was at Not > > Available and the account moved to its best presence Away, the plugin will > > activate. So, that's probably an improvement. Do you know why Away was > > filtered as an originating presence? This doesn't work for the status > > message plugins because the autoaway plugin doesn't overwrite the status > > message with the preset away message (if there is one set), and only > > doesn't overwrite the status message with the preset away message (if there > > is one set) for Away -only-, as the originating presence. > > David Edmundson wrote: > >onRequestedPresenceChanged() signal doesn't set the presence properly > when accounts are disabled in the accounts kcm > > onRequestedPresenceChanged is a slot. I'm confused what you mean. > > If an accunt is disabled doing requestPresence won't do anything. > > >Do you know why Away was filtered as an originating presence? > > If you're already away there's no point setting yourself to away again. > More importantly you don't want to leave being in away when you autoaway gets > deactivated.
*account - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118045/#review57555 ----------------------------------------------------------- On May 7, 2014, 10:29 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118045/ > ----------------------------------------------------------- > > (Updated May 7, 2014, 10:29 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-kded-module > > > Description > ------- > > Use requestedPresence throughtout > > Mixing current + requested will also get you in a mess as things will > often be slightly out for a while. > > > Diffs > ----- > > status-handler.cpp 4b9c25a > autoaway.cpp 13b71a5 > > Diff: https://git.reviewboard.kde.org/r/118045/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
