-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116623/#review57960
-----------------------------------------------------------
Wasn't it a typo in
>> if (handledCallChannels.contains(callChannel)) {
I bet, it should be "if (!handledCallChannels.contains" (i.e. if NOT contains).
Isn't it.
// It brakes call-ui with currently commited behaviour (it doesn't create
windows/doesn't call at all).
- Vadim A. Misbakh-Soloviov
On March 18, 2014, 3:23 p.m., mayank jha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116623/
> -----------------------------------------------------------
>
> (Updated March 18, 2014, 3:23 p.m.)
>
>
> Review request for Telepathy.
>
>
> Bugs: 309146
> http://bugs.kde.org/show_bug.cgi?id=309146
>
>
> Repository: ktp-call-ui
>
>
> Description
> -------
>
> We store the channels handled by a callManager in a list, and upon a new
> request we check if it already exists, only if it is new we open a new
> call-ui window.
>
>
> Diffs
> -----
>
> src/call-handler.h 5fea003
> src/call-handler.cpp f4ced53
>
> Diff: https://git.reviewboard.kde.org/r/116623/diff/
>
>
> Testing
> -------
>
> Made a video call with another person. Clicked the audio and video call
> buttons. The window was not duplicated.
>
>
> Thanks,
>
> mayank jha
>
>
_______________________________________________
KDE-Telepathy mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-telepathy
