On July 1, 2014, 7:41 p.m., Aleix Pol Gonzalez wrote: > > However I can't think of much that I'm very happy with either > > > > Making requestedPresenceType as well is rubbish, you're liable to lose > > messages and having 2 writeable properties for sort of the same thing is > > going to lead to problems. > > Making Tp::Presence a QObject is a massive overcomplication that doesn't > > seem right either. > > > > One option is to have a Q_INVOKABLE on GlobalPresence that returns a > > Tp::Presence?
Or, on the other hand, we can accept this is how we do it given the current API. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119064/#review61426 ----------------------------------------------------------- On July 1, 2014, 2:16 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119064/ > ----------------------------------------------------------- > > (Updated July 1, 2014, 2:16 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-desktop-applets > > > Description > ------- > > We're showing an empty view when we're offline. This should be improved, so I > took the fast and simple approach first. > > > Diffs > ----- > > contactlist/org.kde.ktp-contactlist/contents/ui/ContactList.qml 826465a > > Diff: https://git.reviewboard.kde.org/r/119064/diff/ > > > Testing > ------- > > It's simple and it works. I like it. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
