----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119086/#review61804 -----------------------------------------------------------
KTp/Logger/abstract-logger-plugin.cpp <https://git.reviewboard.kde.org/r/119086/#comment43015> This method should now return TRUE by default. If the result cannot be determined, the default state should be assumed, which in this case is that logging IS enabled. KTp/Logger/log-manager.cpp <https://git.reviewboard.kde.org/r/119086/#comment43016> Same here, I think the default should be TRUE now KTp/Logger/log-manager.cpp <https://git.reviewboard.kde.org/r/119086/#comment43017> This will then have to change too I think - Dan Vrátil On July 3, 2014, 9:48 p.m., Marcin Ziemiński wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119086/ > ----------------------------------------------------------- > > (Updated July 3, 2014, 9:48 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-common-internals > > > Description > ------- > > Added an option to disable or enable logging for entities with an > implementation in tp-logger-plugin. > > > Diffs > ----- > > KTp/Logger/plugins/tplogger/tp-logger-plugin.cpp 8c0cb16 > KTp/Logger/plugins/tplogger/tp-logger-plugin.h 346c233 > KTp/Logger/log-manager.h c5f92d6 > KTp/Logger/log-manager.cpp 7ce4a12 > KTp/Logger/abstract-logger-plugin.cpp 6d387bb > KTp/Logger/abstract-logger-plugin.h 6db98d4 > > Diff: https://git.reviewboard.kde.org/r/119086/diff/ > > > Testing > ------- > > > Thanks, > > Marcin Ziemiński > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
