-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119544/#review63490
-----------------------------------------------------------

Ship it!


Thanks a lot for the patch! Feel free to push it, it looks good.

- Sven Brauch


On July 30, 2014, 8:08 a.m., Daniele E. Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119544/
> -----------------------------------------------------------
> 
> (Updated July 30, 2014, 8:08 a.m.)
> 
> 
> Review request for Telepathy and Sven Brauch.
> 
> 
> Repository: libqinfinity
> 
> 
> Description
> -------
> 
> libqinfinity fails to locate libgsasl on Debian testing, because the name 
> known by pkg-config is not gsasl but libgsasl.
> This small patch fixes it.
> 
> 
> Diffs
> -----
> 
>   CMakeModules/FindGSASL.cmake 174ed5b 
> 
> Diff: https://git.reviewboard.kde.org/r/119544/diff/
> 
> 
> Testing
> -------
> 
> Tested on debian testing, it now properly detects the library.
> Using PKG_SEARCH_MODULE instead of PKG_CHECK_MODULES should ensure that it 
> will still work wherever the name is gsasl, see 
> http://cmake.org/cmake/help/git-master/module/FindPkgConfig.html
> 
> 
> Thanks,
> 
> Daniele E. Domenichelli
> 
>

_______________________________________________
KDE-Telepathy mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-telepathy

Reply via email to