> On Aug. 4, 2014, 9:51 a.m., Martin Klapetek wrote: > > src/call-window.cpp, lines 679-680 > > <https://git.reviewboard.kde.org/r/119467/diff/2/?file=294974#file294974line679> > > > > Are these really needed? The docs are not explicit on this after > > showFullScreen() has been called, but maybe just showNormal() would be > > enough?
I think when i did this it was impossible to make the central widget go to fullscreen if it wasn't an independent window. That's why i need to restart the flags like that. I don't really know if that makes sense. - Ekaitz ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119467/#review63739 ----------------------------------------------------------- On Aug. 2, 2014, 11:28 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119467/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2014, 11:28 a.m.) > > > Review request for Telepathy. > > > Repository: ktp-call-ui > > > Description > ------- > > Implement the main UI in QML (Kadixt patches 1/3) > > > Diffs > ----- > > CMakeLists.txt 8c39e7c > src/CMakeLists.txt 250aeb5 > src/call-window.h 07fd01e > src/call-window.cpp c38112d > src/call-window.ui 32c7dad > src/callwindowui.rc 6c390b9 > src/dtmf-handler.h 91960dc > src/dtmf-handler.cpp d8d7970 > src/dtmf-qml.h PRE-CREATION > src/dtmf-qml.cpp PRE-CREATION > src/dtmf-widget.h 9e1bc73 > src/dtmf-widget.cpp f3436b2 > src/dtmf-widget.ui 67f60b9 > src/qml-interface.h PRE-CREATION > src/qml-interface.cpp PRE-CREATION > src/qml/Main.qml PRE-CREATION > src/qml/core/Button.qml PRE-CREATION > src/qml/core/Dtmf.qml PRE-CREATION > src/qml/core/DtmfButton.qml PRE-CREATION > src/qml/core/Label.qml PRE-CREATION > src/qml/core/Separator.qml PRE-CREATION > src/qml/core/ToggleButton.qml PRE-CREATION > src/qml/core/Toolbar.qml PRE-CREATION > src/qml/core/Tooltip.qml PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119467/diff/ > > > Testing > ------- > > Rebased, patched and cherry-picked until I was red in the face. > > Compiles, not tested beyond that. > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
