----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119753/ -----------------------------------------------------------
(Updated Aug. 13, 2014, 11:46 p.m.) Status ------ This change has been marked as submitted. Review request for Telepathy. Repository: ktp-call-ui Description ------- This review contains two commits: 1) Use install(directory in CMakeLists.txt 2) and add support for DTMF tones A B C D. These are small fixes for issues raised in https://git.reviewboard.kde.org/r/119467 The QChar('A') == button.at(0) test seems a simpler comparison than comparing two QStrings. also that order makes it more robust to typoing =. Diffs ----- src/CMakeLists.txt 4525ebf6f76b6a302950411ceea5f8449bad9e28 src/dtmf-qml.cpp e3a3722994a4529341a153b6467d3271bd2aa591 Diff: https://git.reviewboard.kde.org/r/119753/diff/ Testing ------- Compiled. Launched app. Noticed that I do have a UI (Showing cmake works) and that since I don't have DTMF support in XMPP the DTMF dialpad isn't active. (So no real testing). Thanks, Diane Trout
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
