> On July 25, 2014, 8:21 a.m., David Edmundson wrote: > > src/CMakeLists.txt, line 37 > > <https://git.reviewboard.kde.org/r/119467/diff/1/?file=292723#file292723line37> > > > > There's an install directory command.
Fixed in 08cb87f520acac1b872f48da018ad06ffc32acd6 > On July 25, 2014, 8:21 a.m., David Edmundson wrote: > > src/call-window.cpp, line 61 > > <https://git.reviewboard.kde.org/r/119467/diff/1/?file=292725#file292725line61> > > > > we don't want these TODOs Fixed in e971b09d95b5849a52e75b1fe62c5b19cfd7e217 > On July 25, 2014, 8:21 a.m., David Edmundson wrote: > > src/dtmf-handler.h, line 31 > > <https://git.reviewboard.kde.org/r/119467/diff/1/?file=292728#file292728line31> > > > > random TODO Fixed in 8ac58ccf85800b8933c4c8e8b6e0e64be0acd930 > On July 25, 2014, 8:21 a.m., David Edmundson wrote: > > src/call-window.cpp, line 368 > > <https://git.reviewboard.kde.org/r/119467/diff/1/?file=292725#file292725line368> > > > > All this needs cleaning. Fixed in 7a00c8b643089245c2dade2575217ed67859b171 > On July 25, 2014, 8:21 a.m., David Edmundson wrote: > > src/dtmf-qml.cpp, line 48 > > <https://git.reviewboard.kde.org/r/119467/diff/1/?file=292731#file292731line48> > > > > why not just set this to Tp::DTMFEvent in the first place? Fixed in ba0081ad15a22ce720c6f86664925ffc40f54b9d > On July 25, 2014, 8:21 a.m., David Edmundson wrote: > > src/qml/Main.qml, line 1 > > <https://git.reviewboard.kde.org/r/119467/diff/1/?file=292737#file292737line1> > > > > All need trimming. Pretty sure this was fixed in 5ebf7e88fabb9a945c19ad5d697bd87a5f866cb3 > On July 25, 2014, 8:21 a.m., David Edmundson wrote: > > src/qml/Main.qml, line 101 > > <https://git.reviewboard.kde.org/r/119467/diff/1/?file=292737#file292737line101> > > > > i18n > > Ovidiu-Florin Bogdan wrote: > File does not exist anymore in latest commit in > http://quickgit.kde.org/?p=ktp-call-ui.git&a=shortlog&h=25f1f05c9f6eb7609170f2094f7ddffa10c575da You're probably on the wrong branch. e.g. the kaditx_qml branch has it here http://quickgit.kde.org/?p=ktp-call-ui.git&a=blob&h=90a4e616b3875ba5301143188940a38eb2b0f9d3&hb=caca2696c2de09aa08241bb1215a63cff8eb6bce&f=src%2Fqml%2FMain.qml - Diane ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119467/#review63165 ----------------------------------------------------------- On Aug. 2, 2014, 4:28 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119467/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2014, 4:28 a.m.) > > > Review request for Telepathy. > > > Repository: ktp-call-ui > > > Description > ------- > > Implement the main UI in QML (Kadixt patches 1/3) > > > Diffs > ----- > > CMakeLists.txt 8c39e7c > src/CMakeLists.txt 250aeb5 > src/call-window.h 07fd01e > src/call-window.cpp c38112d > src/call-window.ui 32c7dad > src/callwindowui.rc 6c390b9 > src/dtmf-handler.h 91960dc > src/dtmf-handler.cpp d8d7970 > src/dtmf-qml.h PRE-CREATION > src/dtmf-qml.cpp PRE-CREATION > src/dtmf-widget.h 9e1bc73 > src/dtmf-widget.cpp f3436b2 > src/dtmf-widget.ui 67f60b9 > src/qml-interface.h PRE-CREATION > src/qml-interface.cpp PRE-CREATION > src/qml/Main.qml PRE-CREATION > src/qml/core/Button.qml PRE-CREATION > src/qml/core/Dtmf.qml PRE-CREATION > src/qml/core/DtmfButton.qml PRE-CREATION > src/qml/core/Label.qml PRE-CREATION > src/qml/core/Separator.qml PRE-CREATION > src/qml/core/ToggleButton.qml PRE-CREATION > src/qml/core/Toolbar.qml PRE-CREATION > src/qml/core/Tooltip.qml PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119467/diff/ > > > Testing > ------- > > Rebased, patched and cherry-picked until I was red in the face. > > Compiles, not tested beyond that. > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
