----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119880/#review64969 -----------------------------------------------------------
KTp/telepathy-handler-application.cpp <https://git.reviewboard.kde.org/r/119880/#comment45402> Nitpick? Do we actually need this "QApplication::" namespacing in QApplication subclass? I mean, if in far future we will port this app to QuickControls, here will be QGuiApplication, but probably we can drop namespacing at all. - Alexandr Akulich On Авг. 21, 2014, 4:19 п.п., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119880/ > ----------------------------------------------------------- > > (Updated Авг. 21, 2014, 4:19 п.п.) > > > Review request for Telepathy. > > > Repository: ktp-common-internals > > > Description > ------- > > KApplication is deprecated with Frameworks, this ports it to QApplication > > This also moves the setenv initHack into the applications instantiating the > THA, not sure if this would work but a code like > > int main(int argc, char *argv[]) > { > setenv("KDE_FULL_SESSION", "true", 0); > setenv("KDE_SESSION_VERSION", "5", 0); > > KTp::TelepathyHandlerApplication app(argc, argv); > } > > should also do the trick I believe. > > > Diffs > ----- > > KTp/telepathy-handler-application.h 504ad52 > KTp/telepathy-handler-application.cpp 245ff88 > > Diff: https://git.reviewboard.kde.org/r/119880/diff/ > > > Testing > ------- > > > Thanks, > > Martin Klapetek > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
