-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116940/
-----------------------------------------------------------
(Updated Aug. 25, 2014, 11:15 a.m.)
Review request for Telepathy.
Changes
-------
Simplify the status message compare to also include the presence plugin status
messages in the same buffer. This will prevent all presence plugin updates (and
their attached presence messages) and status message plugin updates from
reaching the disk, though plugin presence updates with empty presence messages
can still end up on disk.
Bugs: 332082, 334492 and 334542
http://bugs.kde.org/show_bug.cgi?id=332082
http://bugs.kde.org/show_bug.cgi?id=334492
http://bugs.kde.org/show_bug.cgi?id=334542
Repository: ktp-kded-module
Description
-------
Move status message plugins into a separate class. New infrastructure to help
mitigate the occurrence of bug #334492 while using status message plugins: 1)
buffering of the last n status messages, and 2) a limiter to help stop flooding
the presence changer. Also strips redundant and disused data structures from
both classes.
This patch returns the ability to engage status message plug-ins from custom
status messages. Also working is the disabling of non-visible status message
plug-ins. State-affinity in the 95% of previously noted cases has been vastly
improved also, the few remaining issues should be due to "lite" protocols that
don't have a full complement of on-line presences.
Diffs (updated)
-----
telepathy-mpris.cpp 44b041fdd3764ee5f67598fcf555a2759d853bdd
tests/CMakeLists.txt 7ec77495417a6790060ea5ea7126c46399dff755
telepathy-kded-module-message-plugin.h PRE-CREATION
telepathy-kded-module-message-plugin.cpp PRE-CREATION
telepathy-kded-module-plugin.h 4c161696a706e82059a7eb314773c3644fe26bd7
telepathy-kded-module-plugin.cpp daf73c66947bc946097de7a8e8a1518555131145
telepathy-mpris.h 05b77c90a50372fd9ed66bde0ab8a287caf34b51
CMakeLists.txt 930267740d0bf26f42a48ea55d77148f87df5369
status-handler.h 06240ff17e22148f2b128bc0eb8cec6d6abe68ff
status-handler.cpp 4b9c25a2ccba451f6e608bb704626e33149108cc
Diff: https://git.reviewboard.kde.org/r/116940/diff/
Testing
-------
Disconnect / reconnect, autoconnect / no autoconnect, suspend / resume. Enable
/ disable via kcm module. Added a new custom presence and engaged the now
playing plugin in the contact list from the new presence. Disabled the plugin
by activating another presence.
Thanks,
James Smith
_______________________________________________
KDE-Telepathy mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-telepathy
