> On Aug. 26, 2014, 12:51 p.m., David Edmundson wrote: > > do we really need a 3rd kded module? Can't this be a tiny dbus-activated > > app? > > Martin Klapetek wrote: > KAccounts have a kded module which reacts on created/removed accounts, > this does not add any other ktp kded module, but a plugin for the KAccounts > kded module. > > David Edmundson wrote: > it says repository: ktp-common-internals.
"...a plugin for the KAccounts kded module." I can't have KAccounts depend on KTp. Therefore I created a plugin inside ktp-common-internals which is loaded by KAccounts kded module. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119931/#review65266 ----------------------------------------------------------- On Aug. 26, 2014, 12:36 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119931/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2014, 12:36 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-common-internals > > > Description > ------- > > KAccounts have a kded module monitoring for accounts-sso accounts changes, > this adds the ktp plugin for it, currently KAccounts supports only direct KTp > accounts (as opposed to "Google Accounts" with chat service, for example) and > the accounts are created using a plugin from accounts-kcm (which uses the UI > plugins from it), we still need to remove the KTp accounts whenever it is > removed from KAccounts > > > Diffs > ----- > > kaccounts/kaccounts-ktp-plugin.cpp PRE-CREATION > CMakeLists.txt 17dc6d8 > kaccounts/CMakeLists.txt PRE-CREATION > kaccounts/kaccounts-ktp-plugin.h PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119931/diff/ > > > Testing > ------- > > > Thanks, > > Martin Klapetek > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
