----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120303/#review67129 -----------------------------------------------------------
global-presence-chooser.cpp <https://git.reviewboard.kde.org/r/120303/#comment46847> This is internally a blocking DBus call. We've had issues with that in the past. global-presence-chooser.cpp <https://git.reviewboard.kde.org/r/120303/#comment46849> How can something be active but not enabled? global-presence-chooser.cpp <https://git.reviewboard.kde.org/r/120303/#comment46850> I'm not sure I get this line, it means if I have a saved status message with the same text as a song title we don't change anything. which means when the song changes this'll change. global-presence-chooser.cpp <https://git.reviewboard.kde.org/r/120303/#comment46848> given we only have one status message plugin, this seems massively over-engineered. - David Edmundson On Sept. 21, 2014, 9:53 a.m., James Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120303/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2014, 9:53 a.m.) > > > Review request for Telepathy. > > > Repository: ktp-contact-list > > > Description > ------- > > Makes the contact list use the dbus interface of the message plugin class to > enable and disable status message plugins. > > > Diffs > ----- > > global-presence-chooser.cpp da6a87b618fe367c7377544a7acd800f4103a749 > > Diff: https://git.reviewboard.kde.org/r/120303/diff/ > > > Testing > ------- > > Compile, run. > > > Thanks, > > James Smith > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
