> On Sept. 21, 2014, 2:32 p.m., David Edmundson wrote: > > Can you talk us through this. > > > > My main comment before was that instead of explaining what was wrong with > > the old system we're just adding more and more code. > > This is quite a bit more. > > James Smith wrote: > It's a more unified way of interacting with the status message plugins, > useful for example to allow each application to more completely control the > status message output. This allows for not only disabling the plugin by user > interaction, but also re-enabling the plugin without needing to go into the > contact list.
I think this is quite overengineered and I (as kded-module maintainer) don't believe we require such complex system for the only two presence plugins we have (auto-away & mpris). Rethinking things - sure, but making them super complex...sorry. Plus, 0.9 is the last kde4 release we'll do and this missed the feature freeze already; for frameworks, I'm considering deprecating the mpris integration altogether, the usage is really low and maintenance/dev costs quite high. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120301/#review67127 ----------------------------------------------------------- On Sept. 21, 2014, 11:53 a.m., James Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120301/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2014, 11:53 a.m.) > > > Review request for Telepathy. > > > Repository: ktp-kded-module > > > Description > ------- > > Adds a DBus adaptor class and a number of methods / properties / signals to > control and interact with the status handler from DBus. > > > Diffs > ----- > > telepathy-module.h 17ef4cef27b90cbced6c66846ed82cb5c36fb532 > telepathy-module.cpp 3c34b6e5e0364334c962b4df0dffc70cffed91bc > CMakeLists.txt a5317b480f2013a1c227c1c7f2da85cad13a64b3 > org.kde.Telepathy.StatusMessagePluginInterface.xml PRE-CREATION > org.kde.Telepathy.xml PRE-CREATION > status-handler.h 06240ff17e22148f2b128bc0eb8cec6d6abe68ff > status-handler.cpp 4b9c25a2ccba451f6e608bb704626e33149108cc > telepathy-module-message-plugin-dbus-interface.h PRE-CREATION > telepathy-module-message-plugin-dbus-interface.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/120301/diff/ > > > Testing > ------- > > Compile, quick runtime check. > > > Thanks, > > James Smith > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
