> On Oct. 15, 2014, 11:11 a.m., Martin Klapetek wrote: > > KTp/Widgets/join-chat-room-dialog.cpp, line 471 > > <https://git.reviewboard.kde.org/r/120588/diff/1/?file=318557#file318557line471> > > > > Shouldn't this be ">=" ? > > Diane Trout wrote: > It should be either >= 2 or > 1, or possibly == 2. The code being > protected accesses 2 elements.
Ah, my bad. Ignore ;) - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120588/#review68435 ----------------------------------------------------------- On Oct. 14, 2014, 8:56 p.m., Diane Trout wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120588/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2014, 8:56 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-common-internals > > > Description > ------- > > I have some inactive accounts and for some rason the Q_FOREACH was > being executed by the readEntry was returning an invalid recent list. > > This handles that case and prevents a crash when accessing off the end > of the list. > > > Diffs > ----- > > KTp/Widgets/join-chat-room-dialog.cpp > 94f1d2402ecba519cd049e704ca884f92b718fac > > Diff: https://git.reviewboard.kde.org/r/120588/diff/ > > > Testing > ------- > > Run ktp with my overly complex configuration. > Click on "Join Group Chat" watch contact list crash. > Apply this patch > Click "Join Group Chat" watch error messages about disabled accounts, and > then join a conference room with a currently active account. > > > Thanks, > > Diane Trout > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
