> On Oct. 25, 2014, 12:14 p.m., Martin Klapetek wrote: > > CMakeLists.txt, line 67 > > <https://git.reviewboard.kde.org/r/120795/diff/1/?file=322019#file322019line67> > > > > That doesn't sound right; especially since qca can have random > > suffixes; this should always use the CMake variable > > Hrvoje Senjan wrote: > i used this, cause it's exported target name
Ahh, I thought it's the plain lib name. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120795/#review69134 ----------------------------------------------------------- On Oct. 25, 2014, 7:21 a.m., Hrvoje Senjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120795/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2014, 7:21 a.m.) > > > Review request for Telepathy. > > > Repository: ktp-auth-handler > > > Description > ------- > > plus other misc. things.. can split the patches up, as not everything's > related > > > Diffs > ----- > > CMakeLists.txt 5994416 > cmake/modules/FindKTp.cmake 8facd12 > cmake/modules/FindQJSON.cmake 4781c0a > main.cpp 19f4b07 > org.freedesktop.Telepathy.Client.KTp.ConfAuthObserver.service.in 928a71d > org.freedesktop.Telepathy.Client.KTp.SASLHandler.service.in b29d7e1 > org.freedesktop.Telepathy.Client.KTp.TLSHandler.service.in e8d6f0f > > Diff: https://git.reviewboard.kde.org/r/120795/diff/ > > > Testing > ------- > > builds against latest frameworks ktp-c-i > > > Thanks, > > Hrvoje Senjan > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
