----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120860/#review69334 -----------------------------------------------------------
Ship it! KTp/logs-importer-private.cpp <https://git.reviewboard.kde.org/r/120860/#comment48471> #include <QStandardPaths> KTp/wallet-interface.cpp <https://git.reviewboard.kde.org/r/120860/#comment48472> Shouldn't this be Q_GLOBAL_STATIC? kpeople/datasourceplugin/im-persons-data-source.cpp <https://git.reviewboard.kde.org/r/120860/#comment48473> {}s - Martin Klapetek On Oct. 28, 2014, 6:51 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120860/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2014, 6:51 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-common-internals > > > Description > ------- > > Should be quite straightforward, but it's better if somebody else can look. > > > Diffs > ----- > > KTp/Declarative/pinned-contacts-model.cpp e972bee > KTp/Declarative/telepathy-manager.cpp 1f7fafa > KTp/Logger/log-manager.cpp 7ce4a12 > KTp/Models/presence-model.cpp b916ca5 > KTp/core.cpp 1888b35 > KTp/error-dictionary.cpp a6179d3 > KTp/logs-importer-private.cpp 74e6f46 > KTp/message-filter-config-manager.cpp 1224ac6 > KTp/message-processor.cpp b461ef8 > KTp/wallet-interface.cpp 575cdf1 > kpeople/datasourceplugin/im-persons-data-source.cpp a005de9 > kpeople/uiplugins/chatplugin/kpeople_chat_plugin.cpp f87253d > otr-proxy/KTpProxy/otr-config.cpp c969172 > > Diff: https://git.reviewboard.kde.org/r/120860/diff/ > > > Testing > ------- > > Not much, everything still builds, can run the components I've tried. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
