----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121413/#review71664 -----------------------------------------------------------
Ship it! KTp/Widgets/add-contact-dialog.cpp <https://git.reviewboard.kde.org/r/121413/#comment49975> qCDebug maybe? KTp/Widgets/join-chat-room-dialog.ui <https://git.reviewboard.kde.org/r/121413/#comment49976> LOL KTp/Widgets/notification-config-dialog.cpp <https://git.reviewboard.kde.org/r/121413/#comment49977> Maybe only call standardButton once? switch? variable? Small nitpicking, looks good. Good job! - Aleix Pol Gonzalez On Dec. 9, 2014, 5:13 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121413/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2014, 5:13 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-common-internals > > > Description > ------- > > As summary > > > Diffs > ----- > > KTp/Widgets/contact-view-widget.cpp e20e6ac > KTp/Widgets/join-chat-room-dialog.h e1d6237 > KTp/Widgets/join-chat-room-dialog.cpp c3cf08f > KTp/Widgets/join-chat-room-dialog.ui e323833 > KTp/Widgets/notification-config-dialog.h a0bc2ea > KTp/Widgets/notification-config-dialog.cpp fe22197 > KTp/Widgets/start-chat-dialog.h cab782a > KTp/Widgets/start-chat-dialog.cpp 58c9987 > KTp/Widgets/start-chat-dialog.ui 213479f > CMakeLists.txt 0dbec08 > KTp/Widgets/CMakeLists.txt b183874 > KTp/Widgets/add-contact-dialog.h 6ec0da5 > KTp/Widgets/add-contact-dialog.cpp 578fcde > KTp/Widgets/add-contact-dialog.ui 63e4b78 > KTp/Widgets/contact-grid-dialog.h 2fc6e16 > KTp/Widgets/contact-grid-dialog.cpp 5fc0b21 > > Diff: https://git.reviewboard.kde.org/r/121413/diff/ > > > Testing > ------- > > > Thanks, > > Martin Klapetek > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
