----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121539/#review72415 -----------------------------------------------------------
Ship it! Ship It! - David Edmundson On Dec. 15, 2014, 7:34 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121539/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2014, 7:34 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-common-internals > > > Description > ------- > > This makes all ktp parts using TelepathyHandlerApplication use the name "KDE > Telepathy", which may be good but it's causing other problems like text-ui > not finding its xml .rc file because it looks in .../KDE Telepathy/... folder > rather than .../ktp-text-ui/... where it is installed. Alternative solution > is to make everything install into KDE Telepathy subfolders. > > I'm not sure which approach is better (hence this review), here's removing > the default and having each ktp part set its own app name. > > From IRC: [20:32:58] <einar77> mck182: right, the same issue breaks config > file migration > > > Diffs > ----- > > KTp/telepathy-handler-application.cpp 8ebf537 > > Diff: https://git.reviewboard.kde.org/r/121539/diff/ > > > Testing > ------- > > ktp-text-ui gets full toolbar again > > > Thanks, > > Martin Klapetek > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
