> On Jan. 6, 2015, 1:22 a.m., Martin Klapetek wrote:
> > Mpris specifications does not really target videos; plus I can't find a 
> > video player that would actually support this, makes me kinda doubt the 
> > usefulness of this (and as said couple times before, please discuss 
> > features first, we hate turning down code that has been already written). 
> > What player did you test this with?
> 
> James Smith wrote:
>     Mpris2 is player-agnostic, the xesam:url is included with dragon and vlc 
> metadata, so the only drawback is accurate server mimetypes in the streaming 
> case. Mpris2 does do well at what the player can pass along, there are some 
> video formats that do include metadata (track / artist for video). There is 
> also a patch (#121387) that simply ignores player tracks (audio or video) if 
> there is insufficient metadata.
>     
>     One of the Tears of Steel Blender Foundation streams (metadata + mime) 
> (http://media.xiph.org/mango/tears_of_steel_1080p.webm) works with Dragon 
> (Phonon+GStreamer) and a few Wikipedia .ogv (e.g. 
> https://upload.wikimedia.org/wikipedia/commons/7/7d/Vela_Pulsar_jet_seen_by_Chandra_Observatory.ogv)
>  have metadata, however their servers don't serve the correct mimetype.
>     
>     I don't know if I'd call this a feature, more of a bugfix in tandem with 
> #121387; video AND bad metadata should be simply ignored in the best of cases 
> due to how bad the status messages can look when there isn't sufficient 
> information. This is probably the best possible alternative.
>     
>     The problem(s) to solve, are that video is not to be mislabelled as 
> audio, and that deficient metadata also doesn't interfere with how "complete" 
> the status message is.

> One of the Tears of Steel Blender Foundation streams (metadata + mime) 
> (http://media.xiph.org/mango/tears_of_steel_1080p.webm) works with Dragon 
> (Phonon+GStreamer) and a few Wikipedia .ogv (e.g. 
> https://upload.wikimedia.org/wikipedia/commons/7/7d/Vela_Pulsar_jet_seen_by_Chandra_Observatory.ogv)
>  have metadata, however their servers don't serve the correct mimetype.

Yes, that's mostly my concern. This will work with one or two players (as much 
as dragon is a real player) and about dozens of videos, for the rest it will 
just be disabled. I don't think it's really worth the maintenance overhead that 
we'd put on ourselves by adding that much complexity for virtually zero gain, 
sorry...


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121641/#review73217
-----------------------------------------------------------


On Jan. 4, 2015, 6:49 a.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121641/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2015, 6:49 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> Video data-specific support for now Playing plugin.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 4a8aa4140e7fcda2fa36437cae98b1129f484fb4 
>   config/telepathy-kded-config.cpp 9c686d1ca54c277e4ef5cfe95232a150f6ea102b 
>   config/telepathy-kded-config.ui 93c06dc74b4dcb37e0473d0debfb5e738a24afa9 
>   telepathy-mpris.h 05b77c90a50372fd9ed66bde0ab8a287caf34b51 
>   telepathy-mpris.cpp ee0e622c68bdd156e45914f542d2fe13f0ddb610 
> 
> Diff: https://git.reviewboard.kde.org/r/121641/diff/
> 
> 
> Testing
> -------
> 
> None.
> 
> 
> Thanks,
> 
> James Smith
> 
>

_______________________________________________
KDE-Telepathy mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-telepathy

Reply via email to