> On Dec. 29, 2014, 2:26 p.m., David Edmundson wrote: > > src/defaultcontactmonitor.cpp, line 38 > > <https://git.reviewboard.kde.org/r/121639/diff/1/?file=335589#file335589line38> > > > > given we now control AbstractContact we can put the ID in that. > > > > Will simplify a few APIs > > Aleix Pol Gonzalez wrote: > So you propose it should be a property? or?
I agree on this, but I want to look into this in a next iteration. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121639/#review72493 ----------------------------------------------------------- On Jan. 7, 2015, 2:39 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121639/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2015, 2:39 p.m.) > > > Review request for KDEPIM, Telepathy, Christian Mollekopf, David Edmundson, > and Martin Klapetek. > > > Repository: libkpeople > > > Description > ------- > > Last week we had a couple of discussions regarding KPeople relationship with > KDE PIM and KContacts and we agreed that we want to keep KContacts as a > framework that is good at dealing with vCards, which leaves KPeople without a > good way to send around its data. > > This patch proposes an internal AbstractContact class that the backends will > have to re-implement. At the moment it only requires a "customProperty" that > lets us fetch whatever is needed. > Furthermore, it also includes a set of convenience methods in PersonData to > have a type-safe API. > > > Diffs > ----- > > src/widgets/persondetailsview.cpp b7535bd > > Diff: https://git.reviewboard.kde.org/r/121639/diff/ > > > Testing > ------- > > Builds, the test passes. ktp tests work, somewhat. > Also there's few tests altogether. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
