----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121657/ -----------------------------------------------------------
(Updated Jan. 9, 2015, 2:02 p.m.) Status ------ This change has been marked as submitted. Review request for Telepathy, David Edmundson and Martin Klapetek. Repository: ktp-common-internals Description ------- Basically ports to AbstractContact instead of using KContacts for passing around the data. The part with the most changes is obviously im-persons-data-source. The idea is that we will have a TelepathyContact that will serve the properties as they're asked. Caching will be possible, but I want to polish that on the next iteration. It's a first iteration of the port, I would treat this as a proof that the kpeople changes will work, so I'd appreciate the nitpicking after the kpeople side is in. Diffs ----- KTp/Models/kpeopletranslationproxy.cpp d61b026 kpeople/actionsplugin/CMakeLists.txt f8fd47b kpeople/actionsplugin/kpeople-actions-plugin.h bacd7b5 kpeople/actionsplugin/kpeople-actions-plugin.cpp da10e36 kpeople/datasourceplugin/im-persons-data-source.cpp 18598d0 kpeople/uiplugins/CMakeLists.txt e9289d7 kpeople/uiplugins/chatplugin/CMakeLists.txt ece13d8 kpeople/uiplugins/chatplugin/kpeople_chat_plugin.h d1d76e2 kpeople/uiplugins/chatplugin/kpeople_chat_plugin.cpp 8b91f0f kpeople/uiplugins/imdetailswidget.h f8d4304 kpeople/uiplugins/imdetailswidget.cpp d33e99a tests/CMakeLists.txt ed01b3f Diff: https://git.reviewboard.kde.org/r/121657/diff/ Testing ------- I see my friends listed if I run ktp_kpeople_list_model_view (some are better friends than others, but I don't think KPeople can fix that yet). Thanks, Aleix Pol Gonzalez
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
