----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122639/#review76299 -----------------------------------------------------------
Ship it! Looks much better, thanks! Regarding the index, you probably will need a method that returns the row for a given Uri. - Aleix Pol Gonzalez On Feb. 19, 2015, 3:48 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122639/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2015, 3:48 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-desktop-applets > > > Description > ------- > > Turns the combobox into a grid with filter (like it used to be sometime ago). > See screenshots. > > > Diffs > ----- > > person/contents/ui/settingsGeneral.qml 25f6df0 > > Diff: https://git.reviewboard.kde.org/r/122639/diff/ > > > Testing > ------- > > Selecting a contact works, everything gets saved properly. > > Problem comes when reopening the config - I'm not sure how to properly find > the index of the saved person. I've tried to add another SortFilterModel and > filter by the personUri role, however that takes only regexp and passing the > uri seems to make it parse like regexp and so returns nothing. > > Any ideas on that? > > > File Attachments > ---------------- > > Before > > https://git.reviewboard.kde.org/media/uploaded/files/2015/02/19/4caf0d02-fabc-4f49-8af1-ced285fa4464__person1.png > After > > https://git.reviewboard.kde.org/media/uploaded/files/2015/02/19/395f3a27-a6d3-469c-81d3-5950d3d59c61__person2.png > > > Thanks, > > Martin Klapetek > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
