----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122794/#review76959 -----------------------------------------------------------
Ship it! Ship It! - Aleix Pol Gonzalez On March 3, 2015, 6:36 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122794/ > ----------------------------------------------------------- > > (Updated March 3, 2015, 6:36 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-common-internals > > > Description > ------- > > Till now the plugin returns only actions for most online contact. With this > it iterates over the subcontacts and creates list of actions for them too, > restoring the 0.9 version behavior. > > Single actions for subcontacts remain broken as the actions plugin now always > operates on person. > > > Diffs > ----- > > kpeople/actionsplugin/kpeople-actions-plugin.cpp 24712a8 > > Diff: https://git.reviewboard.kde.org/r/122794/diff/ > > > Testing > ------- > > See screenshot; one of the actions is there twice because there are two > different contacts from the same account merged into one. Making this more > clever would require changing strings which is not allowed now. > > > File Attachments > ---------------- > > context-menu.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/03/03/0cbbbedd-a0a1-4c5c-a592-3aba41829112__context-menu.png > > > Thanks, > > Martin Klapetek > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
