----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123238/#review78434 -----------------------------------------------------------
+1 - David Edmundson On April 3, 2015, 11:18 a.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123238/ > ----------------------------------------------------------- > > (Updated April 3, 2015, 11:18 a.m.) > > > Review request for Telepathy. > > > Repository: kpeople > > > Description > ------- > > I've been investigating a bug in contact list when unmerging a single contact > from a Person would leave empty rows (and originally would crash), turns out > that removing Contact from Person does not emit the rows removed signal and > so the model then tries to access invalid contact (and we get "out of bounds" > assert). > > > Diffs > ----- > > autotests/fakecontactsource.cpp 3cbeb89 > autotests/personsmodeltest.h 17fc290 > autotests/personsmodeltest.cpp c2a981e > src/personsmodel.cpp 716070c > > Diff: https://git.reviewboard.kde.org/r/123238/diff/ > > > Testing > ------- > > Tests pass, bug is fixed. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
