----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123546/ -----------------------------------------------------------
Review request for Telepathy and Martin Klapetek. Repository: kaccounts-integration Description ------- Connect to QPushButton::clicked signal instead of QPushButton::pressed. This makes it consistent with other buttons, eg. the button action is activated only when releasing the mouse inside the button rect, not immediately on mouse press. It is also needed to change QCommandLinkButton to QPushButton, where it changes the text alignment from left-aligned to center-aligned. I don't know how to replicate the look with QPushButton, but we should not use QCommandLinkButton as it is activated on press (and there is no way to easily change it). Diffs ----- src/accountwidget.cpp a56cf04 src/create.cpp 5e4d46e Diff: https://git.reviewboard.kde.org/r/123546/diff/ Testing ------- Buttons are now activated on mouse release. Thanks, David Rosca
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
