> On May 30, 2015, 11:02 p.m., Alexandr Akulich wrote: > > Hello. > > I know about the issue for a long time, but did not figured out the root of > > problem. > > You're right. :) I just checked it, specs says: "Incoming messages and > > delivery reports are signalled by MessageReceived". I'll fix it tomorrow. > > Next time you'll find a mistake (or some unclear moment) in CM, please let > > me know. :) > > Alexandr Akulich wrote: > Fixed in commit > http://commits.kde.org/telepathy-morse/4161790d13048ed264853197e4a2b92aeb2ccf95 > . Thanks. > > Aleix Pol Gonzalez wrote: > Thank you very much Alexandr! :) > > Now what do we do with this patch?
I think delivery messages should stay in the model, they can sometimes contain useful data from server when the delivery fails for example. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123938/#review80984 ----------------------------------------------------------- On May 29, 2015, 7:58 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123938/ > ----------------------------------------------------------- > > (Updated May 29, 2015, 7:58 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-common-internals > > > Description > ------- > > Currently, when using Telegram, we keep getting empty lines, this skips them. > > OTOH, it _really_ looks like a bug in the CM, as these messages should go > through the received messages rather than the sent, nevertheless I'm unsure > if the patch should still go in. > > > Diffs > ----- > > KTp/Declarative/messages-model.cpp dc1088c > > Diff: https://git.reviewboard.kde.org/r/123938/diff/ > > > Testing > ------- > > The chat plasmoid works fine. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
