----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124137/#review81643 -----------------------------------------------------------
Seems odd to use a mix of Ubuntu's imports and our stuff. Does their import not cover creating accounts? Probably worth exporting our model too, so apps don't have to import two things. src/declarative/kaccountsdeclarativeplugin.cpp (line 2) <https://git.reviewboard.kde.org/r/124137/#comment55961> time machine? src/jobs/createaccount.h (line 41) <https://git.reviewboard.kde.org/r/124137/#comment55958> needs to have notify or constant to not throw warnings src/jobs/createaccount.h (line 48) <https://git.reviewboard.kde.org/r/124137/#comment55960> Q_DECL_OVERRIDE - David Edmundson On June 20, 2015, 11:39 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124137/ > ----------------------------------------------------------- > > (Updated June 20, 2015, 11:39 p.m.) > > > Review request for KDEPIM and Telepathy. > > > Repository: kaccounts-integration > > > Description > ------- > > Adds a plugin and an example that uses it. Seems to work. > > > Diffs > ----- > > CMakeLists.txt 7431dba > example/accounts.qml PRE-CREATION > src/CMakeLists.txt f28ebb6 > src/declarative/CMakeLists.txt PRE-CREATION > src/declarative/kaccountsdeclarativeplugin.h PRE-CREATION > src/declarative/kaccountsdeclarativeplugin.cpp PRE-CREATION > src/declarative/qmldir PRE-CREATION > src/jobs/createaccount.h c9d23b6 > src/jobs/createaccount.cpp 883283f > > Diff: https://git.reviewboard.kde.org/r/124137/diff/ > > > Testing > ------- > > Played around with the example. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
