> On Sept. 10, 2015, 11:03 p.m., Martin Klapetek wrote: > > Can you check if this actually creates any regressions? Perhaps that > > "return false" is there for a reason > > Albert Astals Cid wrote: > No I can't, if you don't want to take the risk i'll discard this.
I'll try it then and report back. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125146/#review85139 ----------------------------------------------------------- On Sept. 10, 2015, 11:01 p.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125146/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2015, 11:01 p.m.) > > > Review request for Telepathy and Martin Klapetek. > > > Repository: ktp-text-ui > > > Description > ------- > > ::event() implementations need to call the parent ::event() otherwise things > like deleteLater which is implemented in QObject::event won't work > > In this case it probably doesn't matter, but it's always good to have "good > code" > > > Diffs > ----- > > lib/chat-search-bar.cpp f0a559f > > Diff: https://git.reviewboard.kde.org/r/125146/diff/ > > > Testing > ------- > > > Thanks, > > Albert Astals Cid > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
