----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127007/#review92173 -----------------------------------------------------------
Fix it, then Ship it! Thanks for fixing this logviewer/log-viewer.cpp (lines 340 - 342) <https://git.reviewboard.kde.org/r/127007/#comment62881> This semantically doesn't make sense - having a method named "clear" that needs a string passed and actually then it decides if it will clear or not. Clear should clear. What I would suggest instead is to revert the changes in this method and just create a lambda: connect(ui->globalSearch, &QLineEdit::textChanged, [=](const QString &text) { if (text.isEmpty()) { slotClearGlobalSearch()}}); - Martin Klapetek On Feb. 8, 2016, 8:28 a.m., Niels Ole Salscheider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127007/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2016, 8:28 a.m.) > > > Review request for Telepathy. > > > Repository: ktp-text-ui > > > Description > ------- > > This fixes the search in the log viewer. > > > Diffs > ----- > > logviewer/log-viewer.h e6b6d3dbab67ceb3286bd402121e1b0504e8a0af > logviewer/log-viewer.cpp 1ae0f7b87b0d8fee0587215fec38fac2af047b9d > > Diff: https://git.reviewboard.kde.org/r/127007/diff/ > > > Testing > ------- > > - Builds > - Searching works again > > > Thanks, > > Niels Ole Salscheider > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
