----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123504/#review92931 -----------------------------------------------------------
I would like to have some investigation if and how we can reuse the Plasma's mpris dataengine for this. In other words, we already have quite a complex implementation available, why reinvent the wheel and give ourselves more maintenace burden when we can share the code. - Martin Klapetek On Feb. 22, 2016, 10:26 a.m., James Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123504/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2016, 10:26 a.m.) > > > Review request for Telepathy. > > > Repository: ktp-kded-module > > > Description > ------- > > New features: > -Much improved multiple player handling; a number of service availability > bugs were fixed. > -Default template changed from 'Now Listening to ...' to 'Now Playing ...' > -Ignore tracks with inadequate metadata > -Separator for empty metadata info fields with (currently) hidden config > > > Diffs > ----- > > config/telepathy-kded-config.cpp 4ed6a16cc8f489794a08a3c031d7a8ec7b010b2d > telepathy-mpris.h 05b77c90a50372fd9ed66bde0ab8a287caf34b51 > telepathy-mpris.cpp ee0e622c68bdd156e45914f542d2fe13f0ddb610 > > Diff: https://git.reviewboard.kde.org/r/123504/diff/ > > > Testing > ------- > > Compile, run. > > > Thanks, > > James Smith > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
