-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128867/#review99307
-----------------------------------------------------------


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Sept. 9, 2016, 12:18 a.m., Alexandr Akulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128867/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2016, 12:18 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> If the sender is selfContact, then the direction should be LocalToRemote even 
> for ReceivedMessages.
> 
> With this fix Scrollback feature in ktp-text-ui starts to partially work.
> 
> Remaining issues (with scrollback):
> - If ktp-proxy is on, then sender of received message forced to the channel 
> target, so all received messages would be "incoming";
> - Messages in TextUi appears in order of receiving. This means that if 
> scrollback received from the newer to older messages, then the older message 
> would be showed at the end (like if it was been just sent).
> 
> 
> Diffs
> -----
> 
>   KTp/message.cpp 566241e 
> 
> Diff: https://git.reviewboard.kde.org/r/128867/diff/
> 
> 
> Testing
> -------
> 
> Compiles, runs. Fixes scrollback for 40% (30% and 30% are broken ktp-proxy 
> and buggy ktp-text-ui, which shows messages in straight instead of 
> chronological message order).
> 
> 
> Thanks,
> 
> Alexandr Akulich
> 
>

Reply via email to