> On Sept. 21, 2016, 8:32 p.m., Aleix Pol Gonzalez wrote: > > otr-proxy/KTpProxy/svc-channel-proxy.cpp, line 63 > > <https://git.reviewboard.kde.org/r/128979/diff/1/?file=477266#file477266line63> > > > > Wait, this should be >=0
No, the fix is correct. :-) If (index of the method < 0) then method is not implemented. No difference with https://git.reviewboard.kde.org/r/128844/diff/ or https://cgit.freedesktop.org/telepathy/telepathy-qt/commit/?id=a7941ac1de8ca9f3599d539646638d0c3c82b7d2 - Alexandr ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128979/#review99376 ----------------------------------------------------------- On Sept. 21, 2016, 7:06 p.m., Alexandr Akulich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128979/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2016, 7:06 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-common-internals > > > Description > ------- > > Fixed incorrect check of adaptee method existance > > See also: https://git.reviewboard.kde.org/r/128844 > > I have no idea how I missed this at the first time. > > > Diffs > ----- > > otr-proxy/KTpProxy/svc-channel-proxy.cpp db5d474 > > Diff: https://git.reviewboard.kde.org/r/128979/diff/ > > > Testing > ------- > > Compiles with less warnings > > > Thanks, > > Alexandr Akulich > >
