> On Jan. 9, 2017, 6:34 a.m., Martin Klapetek wrote: > > As you've started pushing unreviewed changes (your ship it was for a > > different version of the patch), you should either step up as the new > > maintainer of the project and assume full responsibility for your code or > > find someone to review and approve your code. But please don't push > > unreviewed code into master branches, this is in the KDE Telepathy policies > > as well as general KDE guidelines. > > > > https://community.kde.org/KTp/Developers#Workflow
The only public-facing change since David's "Ship it!" was a DBus-specific method name change presenceModelChanged() -> propagationChange(). Also included were the Presence changes which were also "Ship it!" in review #123482 and were, except for the use of KTp::Presence over Tp::Presence, applicable to this fix. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126834/#review101911 ----------------------------------------------------------- On Jan. 9, 2017, 6 a.m., James Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126834/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2017, 6 a.m.) > > > Review request for Telepathy and David Edmundson. > > > Repository: ktp-common-internals > > > Description > ------- > > New features: > -Simplified API, sends and collects changes over DBus. > > > Diffs > ----- > > KTp/Models/presence-model.h 8f206b880f48640626322269a14956f105482f69 > KTp/Models/presence-model.cpp ddc1a7c75f1a452bf3ac2db1aecbd88a5d1ce519 > > Diff: https://git.reviewboard.kde.org/r/126834/diff/ > > > Testing > ------- > > Compile, run. > > > Thanks, > > James Smith > >
