----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130192/#review103502 -----------------------------------------------------------
Fix it, then Ship it! account-status-helper.cpp (line 60) <https://git.reviewboard.kde.org/r/130192/#comment68890> stick in the top before { please Also, can you make this not leak - David Edmundson On July 28, 2017, 6:08 p.m., James Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130192/ > ----------------------------------------------------------- > > (Updated July 28, 2017, 6:08 p.m.) > > > Review request for Telepathy. > > > Bugs: 284517, 293443, 294940, 297924, and 334542 > http://bugs.kde.org/show_bug.cgi?id=284517 > http://bugs.kde.org/show_bug.cgi?id=293443 > http://bugs.kde.org/show_bug.cgi?id=294940 > http://bugs.kde.org/show_bug.cgi?id=297924 > http://bugs.kde.org/show_bug.cgi?id=334542 > > > Repository: ktp-kded-module > > > Description > ------- > > Make unit testing compile. Implement independent account presences and > integrate KActivities. Implement status message parser and integrate with Now > Playing. Add parser unit tests. > > > Diffs > ----- > > CMakeLists.txt c766a5419f60af21cf49903b28a92450be702b78 > account-status-helper.h PRE-CREATION > account-status-helper.cpp PRE-CREATION > autoaway.h 5e2a56100b56e6d21bc649f9032c8bece9031452 > autoaway.cpp 4881c71afab2be2468c3c883523d2844865e6247 > autoconnect.h 0f3ab137cf67cce9c7467144a45d1706ec9cc007 > autoconnect.cpp 99512b265e0e6ae34f83263ffa6337741db652ea > config/CMakeLists.txt c89b7aa5c7f0d140e8b67446710afa085a411cc6 > config/nowplaying-lineedit.h 23f2fee8f164ab762a17e57c70a4e38a33616e5b > config/nowplaying-lineedit.cpp 5bc1f61d0cd0ca43a89e12eab4bcf7e4de540111 > config/nowplaying-listwidget.h f80eb1ecdbacf29887ffa7d522263452a597872e > config/nowplaying-listwidget.cpp 638f4c5b6c1fb4604f99d729d2c220d2ade94677 > config/telepathy-kded-config.h 0400626f205468b1ac9c6964d96a9644ceec32c3 > config/telepathy-kded-config.cpp 88220645c2e119dc7879cdae065cbbf06aa13329 > config/telepathy-kded-config.ui 2b80dfa34381af2e9206384a31c025f9b914854a > org.kde.Telepathy.AccountStatusHelper.xml PRE-CREATION > screensaveraway.h 92344e891ccde16d53771c3e279d845f4d800b2d > screensaveraway.cpp f226564a5bf7b396965b5ae21f81d93b7edc3ef8 > status-handler.h 06240ff17e22148f2b128bc0eb8cec6d6abe68ff > status-handler.cpp 4b9c25a2ccba451f6e608bb704626e33149108cc > status-message-parser.h PRE-CREATION > status-message-parser.cpp PRE-CREATION > telepathy-kded-module-plugin.h 4c161696a706e82059a7eb314773c3644fe26bd7 > telepathy-kded-module-plugin.cpp daf73c66947bc946097de7a8e8a1518555131145 > telepathy-module.h 17ef4cef27b90cbced6c66846ed82cb5c36fb532 > telepathy-module.cpp b74053bc1817d773a4fe37769e42f4013ced5425 > telepathy-mpris.h 05b77c90a50372fd9ed66bde0ab8a287caf34b51 > telepathy-mpris.cpp ee0e622c68bdd156e45914f542d2fe13f0ddb610 > tests/CMakeLists.txt 7ec77495417a6790060ea5ea7126c46399dff755 > tests/status-handling-main.cpp 9fddb13a7c172df2cf3fa8cdf7e5e7836582d1db > tests/status-message-parser.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/130192/diff/ > > > Testing > ------- > > Compile, run. Unit testing. > > > Thanks, > > James Smith > >
