-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130222/#review103591
-----------------------------------------------------------




main-widget.cpp (line 292)
<https://git.reviewboard.kde.org/r/130222/#comment68938>

    this call is expenive, you don't want to do it twice



main-widget.cpp (line 302)
<https://git.reviewboard.kde.org/r/130222/#comment68947>

    why check for a key and not the value of they key?
    
    your other patch does not do removeEntry, so this won't work.


- David Edmundson


On Aug. 10, 2017, 3:24 p.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130222/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2017, 3:24 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-contact-list
> 
> 
> Description
> -------
> 
> Make the dialog appear if there is no config found for other presence 
> controls.
> 
> 
> Diffs
> -----
> 
>   main-widget.h 43334ef8442217154f0df198ce601c9b996914d9 
>   main-widget.cpp 4b4f7004cf6bc5f0db166ce9e13f056508f68484 
> 
> Diff: https://git.reviewboard.kde.org/r/130222/diff/
> 
> 
> Testing
> -------
> 
> Compile, run.
> 
> 
> Thanks,
> 
> James Smith
> 
>

Reply via email to