> On Aug. 10, 2017, 9:48 a.m., David Edmundson wrote:
> > That's the default current behaviour.
> > 
> > Are you trying to add an option to make it always get a prompt when closing 
> > the contact list? 
> > 
> > dont_check_for_plasmoid is set by KMessageBox you'll be conflicting with 
> > that.
> 
> James Smith wrote:
>     This patch makes checking for another presence control before contact 
> list close configurable.
> 
> David Edmundson wrote:
>     So are you trying to add an option, so that the user can choose to 
> always, regardless of whether they have an applet, get a prompt to go offline 
> when they close the contact list?

No, add the dialog's presence applet check option to the kcm because the dialog 
never shows up after configuring offline on close in the kcm so there's no way 
to get it to check for the applet again without going through 2 config files 
and removing the related config entries.

With this patch: Both dialog options are (re-)settable from the kcm.


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130221/#review103592
-----------------------------------------------------------


On Aug. 10, 2017, 10:20 a.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130221/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2017, 10:20 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-kded-module
> 
> 
> Description
> -------
> 
> Add an option to stay online when the presence applet is active to the 
> contact list offline on close.
> 
> 
> Diffs
> -----
> 
>   config/telepathy-kded-config.cpp 88220645c2e119dc7879cdae065cbbf06aa13329 
>   config/telepathy-kded-config.ui 2b80dfa34381af2e9206384a31c025f9b914854a 
> 
> Diff: https://git.reviewboard.kde.org/r/130221/diff/
> 
> 
> Testing
> -------
> 
> Compile, run.
> 
> 
> File Attachments
> ----------------
> 
> Config screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2017/08/10/dee5ab39-88b4-46b7-8b8a-5114161547f1__Screenshot_20170809_211431.png
> Config screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2017/08/10/5af1e06c-a733-4379-99f2-57952d4eb755__Screenshot_20170810_101739.png
> 
> 
> Thanks,
> 
> James Smith
> 
>

Reply via email to