-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Ralf Habacker schrieb: > Patrick Spendrin schrieb: >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 >> >> Ralf Habacker schrieb: >> >>> Hi, >>> >>> since r1025903 krusader sources are fetched from kde svn and it not >>> compilable because of a missing patch, which was applied before the >>> mentioned release. >>> >> the patch wasn't applied for svnHEAD in the old krusader svn head but >> instead only for the 2.0.0-beta2 package. You can still get this package >> using emerge --target=2.0.0-beta2 krusader . If this shouldn't work, >> then please tell me again. > [ 52%] Building CXX object > krusader/Queue/CMakeFiles/Queue.dir/queue_mgr.obj > queue_mgr.cpp > D:\daten\kde\svn\trunk\extragear\utils\krusader\krusader\Queue\queue_mgr.cpp(47) > : error C2057: Konstanter Ausdruck erwartet > D:\daten\kde\svn\trunk\extragear\utils\krusader\krusader\Queue\queue_mgr.cpp(47) > : error C2466: Zuordnung eines Arrays der konstanten Größe 0 nicht möglich. > D:\daten\kde\svn\trunk\extragear\utils\krusader\krusader\Queue\queue_mgr.cpp(47) > : error C2133: 'queueArray': Unbekannte Größe > The related source line is listed below: > > Queue *queueArray [ queuesSize ]; > > There are more issues: Yes, I know, when I moved krusader to the extragear section, I also sent some patches to krusader-devel mailing list (I wasn't sure how to fix the variable length arrays in a nice way). It was added to the bug tracker (http://sourceforge.net/tracker/?func=detail&aid=2865231&group_id=6488&atid=106488) . > > D:\daten\kde\svn\trunk\extragear\utils\krusader\krusader\main.cpp(78) : > error C2057: Konstanter Ausdruck erwartet > D:\daten\kde\svn\trunk\extragear\utils\krusader\krusader\main.cpp(78) : > error C2466: Zuordnung eines Arrays der konstanten Größe 0 nicht möglich. > D:\daten\kde\svn\trunk\extragear\utils\krusader\krusader\main.cpp(78) : > error C2133: 'myArgv': Unbekannte Größe > > char myArgv[argc+2]; > > D:\daten\kde\svn\trunk\extragear\utils\krusader\krusader\main.cpp(88) : > error C2057: Konstanter Ausdruck erwartet > D:\daten\kde\svn\trunk\extragear\utils\krusader\krusader\main.cpp(88) : > error C2466: Zuordnung eines Arrays der konstanten Größe 0 nicht möglich. > D:\daten\kde\svn\trunk\extragear\utils\krusader\krusader\main.cpp(88) : > error C2133: 'addedParams': Unbekannte Größe > > char addedParams[strlen(icon_text)+strlen(icon_name)+2]; >> Please make sure that the directory emerge\portage\testing\krusader is >> deleted > this directory was deleted before >> as this is the old location and might interfere with the new build >> (Maybe this is the problem you found)! >> > It looks no, see above > > Appended is a related patch, should I fix this in kde svn ? Hm, as I said above I didn't commit those changes that I wasn't sure of but instead sent them to the mailing list. If you're sure about your changes, I think you can commit them too. > > Beside the compile problems, krusader crashes in krvfsmodel.cpp:285 > because t is 0 in line 283 > > 283: struct tm* t = localtime((time_t *) & time); > . > 285: QDateTime tmp(QDate(t->tm_year + 1900, t->tm_mon + 1, > t->tm_mday), QTime(t->tm_hour, t->tm_min)); > > This happens on several places in the sources, a possible solution may > be to use the time_t conversation method of QDateTime I can't really see anything speaking against that. > > Regards > Ralf > > regards, Patrick
p.s.: looking at your patch, it is basically the same as I sent to the mailing list. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (MingW32) iEYEARECAAYFAkq/sOsACgkQi49rfdk/G3bEQQCfTKy/ACMrai5P6B3Jzenq+y3p JAsAnRNUfutCdQ5y0HwK4Ct0eafiyaY2 =itVW -----END PGP SIGNATURE----- _______________________________________________ Kde-windows mailing list Kde-windows@kde.org https://mail.kde.org/mailman/listinfo/kde-windows