Patrick Spendrin wrote:
> Peter Kümmel schrieb:
>> Looking at some unit tests I found that a test for KUrl fails:
>
>> FAIL! : KUrlTest::testSetFileName() Compared values are not the same
>> Actual (singleFile.path()): /bar.bin
>> Expected (QString("bar.bin")): bar.bin
>> ..\..\..\..\..\..\svn\trunk\KDE\kdelibs\kdecore\tests\kurltest.cpp(634) :
>> failure location
>
>
>> In KUrl I found this comment:
>> //This is necessary because QUrl has the "path" part including the first
>> slash
>> //Without this QUrl doesn't understand that this is a path, and some
>> operations fail
>> //e.g. C:/blah needs to become /C:/blah
>
>> Therefore I assume the FAIL is a false alarm, see attached patch.
> replace path() with toLocalFile() should help.
But shouldn't we also test if on Windows the string returned by path() starts
with a slash?
And there are no tests for toLocalFile, so I write some.
Peter
_______________________________________________
Kde-windows mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-windows
